feat: enable bouncy castle for sftp #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables Bouncy Castle for SFTP to enhance cryptographic support during SFTP operations.
- Adds an import for JCEProvider.
- Inserts calls to enable Bouncy Castle in two separate locations within the run() method.
Files not reviewed (1)
- src/plugins/sftp/plugin.xml: Language not supported
Comments suppressed due to low confidence (2)
src/plugins/sftp/src/com/foxdebug/sftp/Sftp.java:98
- [nitpick] The call to enable Bouncy Castle here appears to be duplicated later in the method. Consider centralizing this call to reduce redundant initialization.
JCEProvider.enableBouncyCastle(true);
src/plugins/sftp/src/com/foxdebug/sftp/Sftp.java:181
- [nitpick] This duplicate call may be unnecessary if Bouncy Castle is already enabled earlier. Consolidating the initialization could simplify the code.
JCEProvider.enableBouncyCastle(true);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.