feat: improve plugin loading #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- load themes plugin on acode startup and load others after successfully starting acode
There was a problem hiding this comment.
Pull Request Overview
This PR improves the plugin loading process by introducing theme plugin filtering and ensuring theme plugins are loaded on startup while other plugins are loaded later. Key changes include:
- Adding a set of theme identifiers and a helper function (isThemePlugin) to filter theme plugins.
- Modifying the loadPlugins function to handle an "onlyTheme" flag.
- Updating main.js to load theme plugins during startup with appropriate error handling.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/loadPlugins.js | Refactored plugin loading with a new "onlyTheme" flag and added theme plugin logic via a set of identifiers. |
| src/lib/main.js | Adjusted the plugin loading calls in onDeviceReady and loadApp to load theme plugins appropriately. |
Files not reviewed (1)
- biome.json: Language not supported
Comments suppressed due to low confidence (1)
src/lib/main.js:249
- There is a duplicate call to applySettings.afterRender() within the setTimeout callback. Removing one of these calls may prevent redundant re-rendering and improve performance.
applySettings.afterRender();
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the plugin loading process by introducing theme-based filtering and modifying when plugins are loaded during app startup.
- Introduces filtering and early loading for theme plugins using a new isThemePlugin helper.
- Updates the plugin loading invocation in main.js with asynchronous handling and refined error messages.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/loadPlugins.js | Adds theme identifiers and filters plugins based on the current theme. |
| src/lib/main.js | Updates plugin loading calls by wrapping code in async setTimeout callbacks and differentiating between theme and non-theme plugins. |
Files not reviewed (1)
- biome.json: Language not supported
Comments suppressed due to low confidence (1)
src/lib/main.js:242
- The invocation of loadPlugins() does not pass the 'true' argument, yet the error message indicates that theme plugins are expected. Consider changing the call to loadPlugins(true) or updating the error message to accurately reflect the functionality.
await loadPlugins();
There was a problem hiding this comment.
Pull Request Overview
This PR improves the plugin loading functionality by separating theme plugin loading on startup from loading other plugins afterward, and it updates the logging and documentation accordingly.
- In src/lib/main.js, the startup process now loads theme plugins immediately and other plugins later.
- In src/lib/loadPlugins.js, the function now accepts a flag to filter for theme plugins only and refines the filtering logic and logging messages.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/main.js | Modified async behavior in setTimeout and updated plugin loading messages. |
| src/lib/loadPlugins.js | Added a parameter to filter theme plugins and adjusted error logging. |
Files not reviewed (1)
- biome.json: Language not supported
Comments suppressed due to low confidence (1)
src/lib/loadPlugins.js:26
- [nitpick] Consider renaming 'onlyTheme' to 'loadOnlyTheme' for improved clarity regarding the function’s behavior.
export default async function loadPlugins(onlyTheme = false) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1106