feat: inapp acode account login #1244
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/components/sidebar/style.scss: Language not supported
Comments suppressed due to low confidence (3)
src/lib/auth.js:22
- Ensure the DATA_STORAGE variable is defined or imported in this module to avoid runtime errors during token file operations.
return await fsOperation(`${DATA_STORAGE}.acode_token`).exists();
src/components/sidebar/index.js:198
- Use 'userAvatar.el.append(avatarImg)' instead of 'userAvatar.append(avatarImg)' to properly reference the underlying DOM element.
userAvatar.append(avatarImg);
src/components/sidebar/index.js:203
- Use 'userAvatar.el.append(defaultIcon)' instead of 'userAvatar.append(defaultIcon)' to correctly append the element to the DOM.
userAvatar.append(defaultIcon);
|
Before merging I would suggest not displaying email address by default so that we ourselves don't have to spend extra time editing screenshots or screen recordings just to hide it |
That's a public email. |
Some people may want to prefer to use their private email to login with, which for those with privacy concerns is not recommended when the site also publicly displays the email*, although if they used their private email already they should change it to a public email in the account settings for now *In acode website's case the email it's just visible on the profile's URL |
|
You're right... we can mask the email. And use user id instead in the url.
…On Wed, 9 Apr, 2025, 7:09 am peasneovoyager2banana2, < ***@***.***> wrote:
*
<#1244 (comment)>
That's a public email.
Some people may want to prefer to use their private email to login with,
which for those with privacy concerns is not recommended when the site also
publicly displays the email (in acode website case the email it's just
visible on the profile's URL), although if they used their private email
already they should change it to a public email in the settings for now
—
Reply to this email directly, view it on GitHub
<#1244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJHIHI2LXOGRMU5I5JO2I6L2YR23ZAVCNFSM6AAAAAB2T5CO3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBYGA3DGMBYG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
*peasneovoyager2banana2* left a comment (Acode-Foundation/Acode#1244)
<#1244 (comment)>
*
<#1244 (comment)>
That's a public email.
Some people may want to prefer to use their private email to login with,
which for those with privacy concerns is not recommended when the site also
publicly displays the email (in acode website case the email it's just
visible on the profile's URL), although if they used their private email
already they should change it to a public email in the settings for now
—
Reply to this email directly, view it on GitHub
<#1244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJHIHI2LXOGRMU5I5JO2I6L2YR23ZAVCNFSM6AAAAAB2T5CO3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBYGA3DGMBYG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
That's a issue on website but there is no problem with showing email in app(like a profile or something) |
Demo