Fixed select box issue and improved it #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with the select box component by fixing event handling problems, adding a tail element to enable deletion actions, and sanitizing HTML before insertion. Key changes include:
- Introducing tail elements and associated click handlers in both file and directory entries.
- Updating the select dialog to sanitize HTML text via DOMPurify.
- Minor refactoring to improve clarity in event management and DOM cleanup.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/recents.js | Refactored folder and file item rendering with added tail elements and corresponding click handlers. |
| src/dialogs/select.js | Updated select dialog to use template literals, sanitized HTML, and implemented tail click handler registration and cleanup. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tailproperty in select box to add tail elements likexfor deletingxicon in select box to delete recent files/folder(Fixes: Add folder removal option #1130)