feat: add support for compound file paths like .blade.php
#1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for compound file paths like ".blade.php" by introducing a specificity scoring mechanism for mode patterns.
- Added a new helper function getModeSpecificityScore to compute specificity scores based on pattern type.
- Updated the mode iteration to sort modes by descending specificity before matching.
Comments suppressed due to low confidence (2)
src/ace/modelist.js:42
- When two modes have the same specificity score, the current sorting does not enforce a stable order. Consider adding a secondary sort criterion to maintain consistency.
const sortedModes = [...modes].sort((a, b) => { return getModeSpecificityScore(b) - getModeSpecificityScore(a); });
src/ace/modelist.js:9
- Consider adding unit tests for getModeSpecificityScore to validate correct scoring for compound file extensions and anchored patterns.
/**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #744