Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed widget labels overflowing on long strings #3000

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

justindg
Copy link
Contributor

@justindg justindg commented Dec 11, 2022

Fixed widget labels overflowing on long strings

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
🥇
12
▀▀▀▀▀▀
14h 24m
▀▀▀▀▀
6
▀▀▀▀▀▀▀
seabornlee
🥈
6
▀▀▀
9h 27m
▀▀▀
3
▀▀▀
justindg
🥉
1
4h 56m
▀▀
0

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 7.64% // Head: 7.64% // No change to project coverage 👍

Coverage data is based on head (76c0733) compared to base (808930c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #3000   +/-   ##
========================================
  Coverage      7.64%   7.64%           
  Complexity      869     869           
========================================
  Files           640     640           
  Lines         43006   43006           
  Branches       4330    4330           
========================================
  Hits           3289    3289           
  Misses        39439   39439           
  Partials        278     278           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hboon
Copy link
Member

hboon commented Dec 12, 2022

@justindg hotfix means it's going out to the app store, right? :)

@justindg
Copy link
Contributor Author

@justindg hotfix means it's going out to the app store, right? :)

Might've used the wrong term, editing title

@justindg justindg changed the title Hotfix for widget labels overflowing on long strings Fixed widget labels overflowing on long strings Dec 12, 2022
@JamesSmartCell JamesSmartCell merged commit c6a732f into master Dec 15, 2022
@JamesSmartCell JamesSmartCell deleted the adjust-widget-label-ui branch December 15, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants