Token script dynamic attributes #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JamesSmartCell
commented
Dec 18, 2022
- Add dynamic Attributes
- Ensure relevant attributes are updated
- General refactoring as required
- Optimise TokenScript attribute update.
- Ensure relevant attributes are updated - General refactoring as required
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
app/src/main/java/com/alphawallet/app/ui/widget/adapter/TSAttributesAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/service/AssetDefinitionService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/service/AssetDefinitionService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/viewmodel/TokenFunctionViewModel.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/viewmodel/TokenFunctionViewModel.java
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 7.75% // Head: 7.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3013 +/- ##
===========================================
- Coverage 7.75% 7.74% -0.02%
Complexity 890 890
===========================================
Files 641 642 +1
Lines 43108 43189 +81
Branches 4348 4358 +10
===========================================
Hits 3344 3344
- Misses 39475 39556 +81
Partials 289 289
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.