Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change networkId to hex as per iOS #3014

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Change networkId to hex as per iOS #3014

merged 1 commit into from
Dec 19, 2022

Conversation

JamesSmartCell
Copy link
Member

@JamesSmartCell JamesSmartCell commented Dec 18, 2022 •
edited by hboon
Loading

Closes #1904

@JamesSmartCell JamesSmartCell requested a review from hboon December 18, 2022 23:53
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇		 3
▀▀		 5h 36m
▀▀		 3
▀▀▀▀▀▀▀▀▀▀
JamesSmartCell
🥈		 13
▀▀▀▀▀▀▀▀		 19h 7m
▀▀▀▀▀▀▀▀		 0
justindg
🥉		 1
▀		 2m
 0

@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Base: 7.72% // Head: 7.74% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f48b4b9) compared to base (6924a1a).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head f48b4b9 differs from pull request most recent head 25a1daf. Consider uploading reports for the commit 25a1daf to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             master   #3014      +/-   ##
===========================================
+ Coverage      7.72%   7.74%   +0.01%     
- Complexity      884     890       +6     
===========================================
  Files           641     642       +1     
  Lines         43081   43189     +108     
  Branches       4348    4358      +10     
===========================================
+ Hits           3329    3344      +15     
- Misses        39468   39556      +88     
- Partials        284     289       +5
Impacted Files Coverage Δ
...et/app/entity/tokenscript/TokenscriptFunction.java 0.63% <0.00%> (-0.01%) ⬇️
...lphawallet/app/service/AssetDefinitionService.java 5.93% <0.00%> (-0.19%) ⬇️
...a/com/alphawallet/app/ui/AssetDisplayActivity.java 0.00% <0.00%> (ø)
.../java/com/alphawallet/app/ui/FunctionActivity.java 0.00% <0.00%> (ø)
.../main/java/com/alphawallet/app/ui/NFTActivity.java 0.00% <0.00%> (ø)
...com/alphawallet/app/ui/NFTAssetDetailActivity.java 0.00% <0.00%> (ø)
...awallet/app/ui/RedeemSignatureDisplayActivity.java 0.00% <0.00%> (ø)
...ain/java/com/alphawallet/app/ui/TokenActivity.java 0.00% <0.00%> (ø)
.../com/alphawallet/app/ui/TokenFunctionActivity.java 0.00% <0.00%> (ø)
...app/ui/widget/adapter/NonFungibleTokenAdapter.java 0.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hboon
hboon approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@hboon hboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I know why it didn't work the last time now. See #1904 (comment)

@JamesSmartCell JamesSmartCell merged commit dc22caa into master Dec 19, 2022
@JamesSmartCell JamesSmartCell deleted the fix-provider-issue branch December 19, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboon hboon hboon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make chain ID in engine.chainId be hex encoded
2 participants
@JamesSmartCell @hboon