Use relative reference to include ir_DistanceWidthProtocol.hpp in IRremote.hpp #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to use local reference for ir_DistanceWidthProtocol.hpp for consistency/to prevent errors if not installed in global Arduino libraries location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference to include ir_DistanceWidthProtocol.hpp used angled brackets syntax, which breaks if the library is installed anywhere other than the global Arduino libraries folder.
This simple PR changes the reference to include the file from the local directory using relative "" syntax instead, which also is consistent with the approach used for other header file includes used in the rest of the library.