Skip to content

Add Lego Power Functions Receiver. #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mwinters-stuff
Copy link

Adds the Lego Power Functions IR Protocol Receiver.

Adds the Lego Power Functions IR Protocol Receiver.
@AnalysIR
Copy link
Contributor

AnalysIR commented Feb 9, 2016

I suggest you rename your defines and functions to include some identification of the device

e.g DECODE_POWERFUNCTIONS
could refer to any device & does not tell other users which device this is for & may make future debugging difficult.

Change _POWERFUNCTIONS to _LEGO_POWERFUNCTIONS
Change function names to LegoPowerFunctions
@mwinters-stuff
Copy link
Author

Hi.
Changed the defines and function names.. Should be a bit less "confusing" now.. :)

@z3t0
Copy link
Collaborator

z3t0 commented Feb 13, 2016

I will add the necessary info in the changelog and merge this once I get a chance, if possible can you list the changes in the changelog yourself? to speed things up, otherwise I will definitely get to it albeit eventually.

@z3t0 z3t0 self-assigned this Feb 17, 2016
@z3t0 z3t0 added New labels Feb 17, 2016
@nwegner
Copy link

nwegner commented Jan 10, 2017

Has to be synced with PR#309 already providing Lego Power Functions send functionality

@ArminJo ArminJo removed the New label Jul 3, 2020
@ArminJo ArminJo force-pushed the master branch 3 times, most recently from 308a1c6 to e8f8f2d Compare September 16, 2020 11:13
@ArminJo ArminJo force-pushed the master branch 3 times, most recently from c606b7e to 052e160 Compare October 12, 2020 09:11
@ArminJo
Copy link
Collaborator

ArminJo commented Oct 19, 2020

Manually added for version 2.8.0

@ArminJo ArminJo closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants