Move board specific configuration info to new file boarddefs.h. #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
far too many emails for things that should be an issue or PR
updated readme email notice
|
Brilliant idea. But seems to be out of date with the base branch, feel free to rebase it or I will definitely do so when I get a chance |
|
Thanks for your hard work again! |
Theaninova
pushed a commit
to Theaninova/Arduino-IRremote
that referenced
this pull request
Dec 2, 2023
Move board specific configuration info to new file boarddefs.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to move board definitions to its own file,
boarddefs.h. There are two reasons for this change:IRremoteInt.h: typedefs, defines of different types including user preferences, and a "data base" of board specific information. This is not a well organized system. The fix moves all properties (present and, hopefully, future) to a new file.boarddefs.hinto another project is a sensible thing to do.... and this exactly what I like to do in Infrared4Arduino