Skip to content

renamed "boarddefs.h" to "IRremoteBoardDefs.h" #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

renamed "boarddefs.h" to "IRremoteBoardDefs.h" #405

wants to merge 2 commits into from

Conversation

z3t0
Copy link
Collaborator

@z3t0 z3t0 commented Jan 21, 2017

#375

Waiting for confirmation by at least another contributor before merge into master

@z3t0
renamed "boarddefs.h" to "IRremoteBoardDefs.h" to avoid possible
98d6a2c 
conflcits. This was suggested in #375 and aims to prevent a **possible**
issue.
bengtmartensson
bengtmartensson approved these changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@bengtmartensson bengtmartensson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Nay.

@z3t0
Copy link
Collaborator Author

z3t0 commented Mar 26, 2017

need to update the branch

@z3t0 z3t0 self-assigned this Mar 26, 2017
@z3t0 z3t0 mentioned this pull request May 25, 2020
Closed
@bengtmartensson
Copy link
Contributor

Since the said file has been relocated to a subdirectory (private) it is not exported, the reason for the renaming is no more existing. I recommend that this PR is not merged.

@ArminJo
Copy link
Collaborator

ArminJo commented Jun 24, 2020 •
edited
Loading

Since the boarddefs.h is only referenced once in IRremoteInt.h, I would propose to do the renaming,
It is faster done, than writing this comment.
But I would do it manually not using this PR.

@ArminJo ArminJo closed this in e82abc9 Jun 24, 2020
@ArminJo ArminJo deleted the header branch August 11, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengtmartensson bengtmartensson bengtmartensson approved these changes

Assignees

@z3t0 z3t0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z3t0 @bengtmartensson @ArminJo