Salocinx master #415
Closed
Salocinx master #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conflcits. This was suggested in #375 and aims to prevent a **possible** issue.
…into salocinx-master
|
The branch has become out of date again, should be a trivial fix. Also the new protocol needs to be added to the relevant example sketches. And we need documentation to explain the protocol specs |
308a1c6 to
e8f8f2d
Compare
c606b7e to
052e160
Compare
|
Please rebase the code if the protocol is still required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#413
@salocinx
I needed to recreate the PR to add the changelog commit. I will give the code another look in the next few days and then merge within the week.
Thank you very much! Your contribution is greatly appreciated. If possible, could you summarize in a sentence or two any difficulties you may have had in creating this protocol spec? Just something to add to the wiki for any future coders that want to add their own protocols.