Skip to content

Merge #522 #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Merge #522 #527

wants to merge 6 commits into from

Conversation

z3t0
Copy link
Collaborator

@z3t0 z3t0 commented Sep 24, 2017

See #522

The reason for this change is that I was informed by a community
member that the Pro Micro board does not have the default pin 13. This
causes many issues for beginners that are not familiar with the inner
workings of the library. However, I am concerned about this being a
breaking change. If there are serious issues I may just end up adding
a tutorial in the FAQ for beginners, informing them how they may
change the default pins.
This reverts commit 20a4d97, reversing
changes made to 47aadf5.
Credits: https://github.com/LarsWH
Excerpt from PR:
```
Hi,

I added support for 'RC5 extended' in order to make this project:
https://www.instructables.com/id/Remote-Control-for-Lava-mMotion-Swing-Mounting-Bra/

The modification is working nicely in this single application. It has
not been tested elsewhere.

(I am new to Git and this is my first pull request ever. So please
excuse me if I have messed something up)

Kind regards,
Lars
```

Merged #522
@z3t0
Copy link
Collaborator Author

z3t0 commented Sep 24, 2017

Something definitely seems to be broken... Out of time for now but will take a look later.

@z3t0
Copy link
Collaborator Author

z3t0 commented Sep 24, 2017

the dev branch is old... using beta now I think

@ArminJo
Copy link
Collaborator

ArminJo commented Jul 2, 2020

I compared it with the master head and all changes seem to be included now. 👍

@ArminJo ArminJo closed this Jul 2, 2020
@ArminJo ArminJo deleted the merge-pr-522 branch August 11, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants