Skip to content

Add SAMSUNG to IRRecord.ino #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

Add SAMSUNG to IRRecord.ino #688

merged 1 commit into from
May 21, 2020

Conversation

Kruemmelspalter
Copy link
Contributor

It wasn't included and said: "Unexpected codeType 7"

It wasn't included and said: "Unexpected codeType 7"
@ArminJo
Copy link
Collaborator

ArminJo commented May 20, 2020

Are you aware that this repo is abandoned for 3 years?
Better try IRMP it includes 50 protocols.

@Kruemmelspalter
Copy link
Contributor Author

Oh... I didn't know that. I followed a tutorial and it said that I should use this

@AnalysIR
Copy link
Contributor

@z3t0

@z3t0 z3t0 merged commit 6c0a603 into Arduino-IRremote:master May 21, 2020
@z3t0
Copy link
Collaborator

z3t0 commented May 21, 2020

Merged.
@AnalysIR thanks for the ping!

@Kruemmelspalter thank you for the fix! Much appreciated.

As for the status of this library, it is mostly unmaintained. However, I think most of the functionality is there and there aren't a lot of changes that make sense. The library is quite complete. We could continue adding protocols and support for more and more boards but I don't think that's particularly useful as users can do this by forking. We can't cover the use-cases of all users and there has been a lot of documentation through GitHub issues and external blogs which explain how to expand the library for more exotic uses. That said, I welcome patches and bug fixes and will always be happy to merge those in, assuming I see the patch, pinging me with @ is probably a good way to get my attention when its important and I seem unresponsive.

@ArminJo
Copy link
Collaborator

ArminJo commented May 21, 2020

@z3t0
Glad to hear from you.
Would it not be a good Idea to give e.g. @AnalysIR maintenance rights, to tag issues and close a few and maybe close some ancient and merge some sensible pull requests?
For every developer it is a great effort to browse through all the issues and pull requests and then looking to some forks, if his problem was solved there.

It is just an idea, but it could make programming life easier for some Arduino enthusiasts.

Best Regards
Armin

@Kruemmelspalter Kruemmelspalter deleted the patch-1 branch May 22, 2020 07:01
@z3t0
Copy link
Collaborator

z3t0 commented May 23, 2020

Hi Armin, thank you for the suggestion.

I am definitely open and willing to add more users to the repository so that it can be governed and maintained without relying on me. As has been made clear by the state of this repo (sorry!) I haven't been very reliable here.

I would prefer to add contributors that have a record of being involved within the Arduino-IRremote community and someone like @AnalysIR is perfect for that. If they are willing then I would be happy to make that happen. Let me know!

@ArminJo
Copy link
Collaborator

ArminJo commented May 23, 2020

Hi @AnalysIR,
I would very much appreciate, if you are willing to put some effort in maintaining this repository.
Also for me you are the perfect person for this 🥇 .
If you like,I can support you by e.g. closing issues and testing pull requests.

Make us happy!

Armin

@AnalysIR
Copy link
Contributor

@z3t0 As previusly discussed, I am not in a position to do this, as our AnalysIR software applications and IR hardware modules take priority for us, in addition to the other reasons I provided at the time. However, I will continue to provide end-user support here when possible.

In the future we may create an IRremote fork dedicated to our recently launched KontroLIR remote control, but so far it has not been neccessary as IRremote functions very well indeed. We also plan to release a version of our LearnIR V2 hardware (i.e. USB Dongle) which runs IRremote.(instead of LearnIR)

@z3t0
Copy link
Collaborator

z3t0 commented May 23, 2020

@AnalysIR Absolutely completely understood, thank you for your continuing support for the community.

@ArminJo If you are interested feel free to help clean up issues and PRs. I think for the most part a lot of the issues are really feature requests or supports for help, few are bugs. And for the PRs a lot of them are really out of the scope of this library.

If you would be interested I can look into adding you as a maintainer of the repo and then you should be able to close/open issues and add labels etc. The only concern I have is that I don't see this library as needed much more development. Bug fixes and cleaning up are okay, but otherwise I tend to see the library as "complete". If your opinions on that differ then we can certainly discuss and try to come up with a vision for this library that is more suited to the community!

@z3t0
Copy link
Collaborator

z3t0 commented May 23, 2020

Also this discussion may be more appropriate in #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants