fix OOB on String.UTF8.encode using nullTerminated = true #2173

romdotdog · 2021-12-11T17:58:26Z

fixes #2021

Examples

before it worked like this

String.UTF8.byteLength("a\0", true); // -> 2
String.UTF8.encode("a\0", true); // writes 0x61, 0x00, and then another 0x00

now it works like this

String.UTF8.byteLength("a\0", true); // -> 2
String.UTF8.encode("a\0", true); // writes 0x61, 0x00 and breaks because of the null

tests/compiler/std/string-encoding.ts

dcodeIO · 2021-12-13T07:06:20Z

Thanks :)

romdotdog added 2 commits December 11, 2021 11:54

fix

3bbf760

recreate fixtures

879f35b

dcodeIO reviewed Dec 12, 2021

View reviewed changes

tests/compiler/std/string-encoding.ts Outdated Show resolved Hide resolved

update test

d7626eb

romdotdog requested a review from dcodeIO December 12, 2021 18:24

dcodeIO merged commit 09beb42 into AssemblyScript:main Dec 13, 2021