etag implementation #7438
Merged
etag implementation #7438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
bryevdv
reviewed
Sep 25, 2019
...ration/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py
Outdated
Show resolved
Hide resolved
bryevdv
reviewed
Sep 25, 2019
...ration/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py
Outdated
Show resolved
Hide resolved
bryevdv
reviewed
Sep 25, 2019
...ration/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py
Outdated
Show resolved
Hide resolved
bryevdv
reviewed
Sep 25, 2019
...ration/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py
Outdated
Show resolved
Hide resolved
bryevdv
reviewed
Sep 25, 2019
...ration/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py
Outdated
Show resolved
Hide resolved
bryevdv
approved these changes
Sep 26, 2019
xiangyan99
added a commit
that referenced
this pull request
Oct 2, 2019
* Check in app config preview 4 * pylint fix * re-generate code per swagger change * add 409(AppConfigResourceReadOnlyError) support * Rename AppConfigResourceReadOnlyError to ResourceReadOnlyError * pylint fix * add support for set_read_only & clear_read_only * add support for has_changed + tests * etag implementation (#7438) * etag implementation * update name * address review feedback * mark etag type None-able * pylint fixes * use fields rather than select * fix pylint * add dev-requirements * update readme * update tests * remove has_changed * add typing_extensions into azure core deps * update typing dep * update deps * simplify error map * add check to make sure etag is not double quoted * don't support conditionally set/release read only for this release
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
* Check in app config preview 4 * pylint fix * re-generate code per swagger change * add 409(AppConfigResourceReadOnlyError) support * Rename AppConfigResourceReadOnlyError to ResourceReadOnlyError * pylint fix * add support for set_read_only & clear_read_only * add support for has_changed + tests * etag implementation (Azure#7438) * etag implementation * update name * address review feedback * mark etag type None-able * pylint fixes * use fields rather than select * fix pylint * add dev-requirements * update readme * update tests * remove has_changed * add typing_extensions into azure core deps * update typing dep * update deps * simplify error map * add check to make sure etag is not double quoted * don't support conditionally set/release read only for this release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.