Skip to content

Distutils readme upd #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Distutils readme upd #955

wants to merge 4 commits into from

Conversation

atailh4n
Copy link

@atailh4n atailh4n commented Jun 4, 2025 •
edited
Loading

Added distutils warning

A GIF or MEME to give some spice of the internet

Description

Since Python 3.12, distutils removed, according to this, many users having problems with
installation. Using setuptools module fixes that

Motivation and Context

issue
Since Python 3.12, distutils removed, according to this, many users having problems with
installation. I forgot to the add this 1 year ago. Sorry for that.

How Has This Been Tested?

I mean if you try to install brain.js from zero, this error thrown 99%

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

cclauss
cclauss approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! https://docs.python.org/3/library/distutils.html -- distutils was removed from Python >= 3.12.

@atailh4n
Copy link
Author

atailh4n commented Jun 4, 2025

Hey, I'll add node-gyp too, I'll update README 1 more time.

@atailh4n
Copy link
Author

atailh4n commented Jun 4, 2025

I've updated the NOTE and I've added refferences correctly. I've added https://docs.python.org/3/library/distutils.html too.

cclauss
cclauss reviewed Jun 4, 2025
View reviewed changes
@atailh4n @cclauss
Commit suggestion for README
500dd00 
Co-authored-by: Christian Clauss <cclauss@me.com>
@imnetcat
Copy link

imnetcat commented Aug 7, 2025

as a new user expirienced fresh installation of brain js and stuck with this issue for a while wanna plus up for this PR
(why I didn't read issues and PRs before I wasted hour to finally figure out an issue and solve it for myself agh)

@atailh4n
Copy link
Author

atailh4n commented Aug 7, 2025 •
edited
Loading

as a new user expirienced fresh installation of brain js and stuck with this issue for a while wanna plus up for this PR (why I didn't read issues and PRs before I wasted hour to finally figure out an issue and solve it for myself agh)

Did this pr resolved your issue? I appreciate your answer.

I've been there once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atailh4n @imnetcat @cclauss