Skip to content

Adding uniques #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding uniques #88

wants to merge 1 commit into from

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Jan 26, 2024

This patch add ability get list of SList unique definitions.

@steweg
Adding uniques
b7dd6cf 
This patch add ability get list of SList unique definitions.
This was referenced Jan 26, 2024
Closed
Closed
@samuel-gauthier
Copy link
Collaborator

samuel-gauthier commented Jan 27, 2024 •
edited
Loading

I pushed your commit with slight changes:

  • removed the check on self.cdata_list and self.cdata_list.uniques, which did not seem useful
  • added a test case with a list without unique field
  • reworded the commit log

Thanks!

@steweg steweg deleted the feature/uniques branch January 31, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steweg @samuel-gauthier