Skip to content

Fix #10 declaration #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 16, 2022
Merged

Fix #10 declaration #12

merged 5 commits into from
Dec 16, 2022

Conversation

Erwane
Copy link
Collaborator

@Erwane Erwane commented Dec 15, 2022

Fix issue #10 and compatibility with cake4.4.
Code clean.
Same thing should be done for 3.x branch

@Erwane Erwane requested a review from Holt59 December 15, 2022 12:42
Holt59
Holt59 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@Holt59 Holt59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I've kind of been gone from this for a long time so you're probably a better judge than me anyway. ;)

@Erwane
Copy link
Collaborator Author

Erwane commented Dec 15, 2022

maybe this https://github.com/FriendsOfCake/bootstrap-ui is a good alternative ?
and some improvements could be pushed to this project ?

@Erwane Erwane merged commit fc2a8a6 into v4.x Dec 16, 2022
@Erwane Erwane mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holt59 Holt59 Holt59 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erwane @Holt59