Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not Appstore safe? #22

Open
4 tasks done
jeanmartin opened this issue Jan 22, 2019 · 1 comment
Open
4 tasks done

Not Appstore safe? #22

jeanmartin opened this issue Jan 22, 2019 · 1 comment
Assignees
@CaliCastle
Labels
bug Something isn't working

Comments

@jeanmartin
Copy link

✔️ Issue Checklist

✍🏻 Issue Description

This line

PopMenu/PopMenu/View Controller & Views/PopMenuViewController.swift

Line 88 in 48c9243

if let buttonView = sourceBarButtonItem.value(forKey: "view") as? UIView {
seems to be using a private API increasing the chance of getting rejected for the app store (according to https://forums.developer.apple.com/thread/87823 which also states this might fail on iOS 11).
@CaliCastle CaliCastle self-assigned this Jan 22, 2019
@CaliCastle CaliCastle added the bug Something isn't working label Jan 22, 2019
@CaliCastle
Copy link
Owner

I didn't know that, I used it in my other project and passed TestFlight, but that's a good point and thanks for posting that forum link, I'll fix it in a minor update, thanks!

CaliCastle added a commit that referenced this issue Mar 4, 2019
@CaliCastle
Fix #22, use customView of UIBarButtonItem instead
bf0cf5c
CaliCastle added a commit that referenced this issue Apr 6, 2019
@CaliCastle
Fix #22, use customView of UIBarButtonItem instead
cecaea9
chunxige added a commit to chunxige/PopMenu that referenced this issue Oct 8, 2023
@chunxige
Merge branch 'develop'
ba164ec 
* develop:
  Supported swift 5 + Xcode 10.3. (CaliCastle#46)
  Fix CaliCastle#22, use customView of UIBarButtonItem instead
  Add example of gesture driven PopMenu presentation.
  Add a way to present popMenu from PopManager with a gesture.
  Migrate example with Xcode10.2
  Migrate with Xcode10.2
  Update README.md

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaliCastle CaliCastle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeanmartin @CaliCastle