Allow SQL functions to inline in the presence of costly parameter functions #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inline() function, so that PostGIS sql language functions will correctly inline even when they have been decorated with higer-than-default costs. Because the Carto 2.4 PostGIS branch does include functions decorated with higher costs, this patch is important to ensure that unindexed accesses do not occur. The high cost functions are required to induce the PgSQL planner to parallelize spatial operations a little more aggressively than standard database functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove parameter function cost tests from the
inline() function, so that PostGIS sql language
functions will correctly inline even when they
have been decorated with higer-than-default costs.
Because the Carto 2.4 PostGIS branch does include
functions decorated with higher costs, this
patch is important to ensure that unindexed
accesses do not occur. The high cost
functions are required to induce the PgSQL
planner to parallelize spatial operations
a little more aggressively than standard
database functions.
This patch will never be applied to PgSQL core, the
real patch will probably be a more generic fix to allow
costly nodes to be cached during execution.
https://www.postgresql.org/message-id/6480.1510861492@sss.pgh.pa.us