Skip to content

Fixed issue with NullPointerException with addOnTutorialPageChangeListener() called before onCreate() #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Fixed issue with NullPointerException with addOnTutorialPageChangeListener() called before onCreate() #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

Version | Changes
--- | ---
v.1.0.8 | Fixed issue with NullPointerException with addOnTutorialPageChangeListener() called before onCreate()
v.1.0.7 | <ul><li>Fixed import for SupportTutorialFragment</li><li>Updated versions of dependencies</li></ul>
v.1.0.6 | <ul><li>Added new simple way of creation of tutorial</li><li>Fixed memory leaks issues</li><li>Updated default sizes of page indicator's elements</li><li>Updated default colors of page indicator</li><li>Updated versions of dependencies</li><li>Removed unused or unnecessary methods</li></ul>
v.1.0.5 | <ul><li>Fixed NullPointerException & IndexOutOfBoundsException inside ViewPager.</li><li>Added SlidingTutorialViewPager</li></ul>
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION_NAME=1.0.7
VERSION_CODE=17
VERSION_NAME=1.0.8
VERSION_CODE=18
GROUP=com.cleveroad

POM_DESCRIPTION=Sliding tutorial is simple library that help other developers easy create great tutotial
Expand Down
4 changes: 2 additions & 2 deletions lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ android {
defaultConfig {
minSdkVersion 14
targetSdkVersion 25
versionCode 17
versionName "1.0.7"
versionCode 18
versionName "1.0.8"
}
buildTypes {
release {
Expand Down
7 changes: 6 additions & 1 deletion lib/src/main/java/com/cleveroad/slidingtutorial/TutorialFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ public int getSeparatorResId() {
}
};



/**
* Create new {@link TutorialOptions.Builder} instance.
*
Expand All @@ -123,11 +125,14 @@ public static TutorialFragment newInstance(@NonNull TutorialOptions tutorialOpti
return new TutorialFragmentImpl(tutorialOptions);
}

public TutorialFragment() {
mTutorial = new TutorialImpl<>(mInternalFragment);
}

@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setRetainInstance(true);
mTutorial = new TutorialImpl<>(mInternalFragment);
}

@Override
Expand Down
5 changes: 4 additions & 1 deletion lib/src/main/java/com/cleveroad/slidingtutorial/TutorialSupportFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,14 @@ public static TutorialSupportFragment newInstance(@NonNull TutorialOptions tutor
return new TutorialSupportFragmentImpl(tutorialOptions);
}

public TutorialSupportFragment() {
mTutorial = new TutorialImpl<>(mInternalFragment);
}

@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setRetainInstance(true);
mTutorial = new TutorialImpl<>(mInternalFragment);
}

@Override
Expand Down