Skip to content

Fix Multi-line and Multi-selection Indentation and Keyboard Shortcuts #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 17, 2025
Merged

Fix Multi-line and Multi-selection Indentation and Keyboard Shortcuts #305

merged 5 commits into from
Apr 17, 2025

Conversation

hi2gage
Copy link
Contributor

@hi2gage hi2gage commented Apr 12, 2025 •
edited
Loading

Blocked until CodeEditApp/CodeEditTextView#87 is merged

Description

Updates indentation for multi line and multi selection indentation. Selection will remain after indentation is completed.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

indent_demo.mov

@thecoolwinter
Copy link
Collaborator

thecoolwinter commented Apr 14, 2025 •
edited
Loading

@hi2gage I just merged that update, it should work now if you merge from main.

@hi2gage hi2gage force-pushed the fix_multi-line_indent branch from b4c3b15 to e0ab576 Compare April 14, 2025 20:17
@hi2gage
Copy link
Contributor Author

hi2gage commented Apr 14, 2025

@thecoolwinter Thank you! Just pushed those changes

@thecoolwinter thecoolwinter merged commit 15798b8 into CodeEditApp:main Apr 17, 2025
2 checks passed
@thecoolwinter
Copy link
Collaborator

Awesome work, thank you!

@austincondiff austincondiff mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi2gage @thecoolwinter