Skip to content

Fix Gutter Position On Small Documents #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Apr 22, 2025

Description

Fixes an issue where on small documents the text view / scroll view would get messed up when placing the gutter view relative to the top padding. This makes the y position relative to the text view's y position.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before, would only appear on small files (1-3 lines):

Screenshot 2025-04-22 at 10 40 16 AM

After:

Screenshot 2025-04-22 at 10 36 08 AM

@thecoolwinter thecoolwinter marked this pull request as draft April 22, 2025 16:13
@thecoolwinter thecoolwinter marked this pull request as ready for review April 23, 2025 14:54
@thecoolwinter thecoolwinter changed the title Fix Gutter Ambiguous Position Fix Gutter Position on Small Documents Apr 23, 2025
@thecoolwinter thecoolwinter changed the title Fix Gutter Position on Small Documents Fix Gutter Position On Small Documents Apr 23, 2025
@thecoolwinter thecoolwinter merged commit 412b0a2 into CodeEditApp:main Apr 23, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/gutter-ambiguous-position branch April 23, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant