-
Notifications
You must be signed in to change notification settings - Fork 100
Improve Editor Configuration, Rename to SourceEditor
#336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thecoolwinter
merged 15 commits into
CodeEditApp:main
from
thecoolwinter:feat/editor-configuration
Jun 23, 2025
Merged
Improve Editor Configuration, Rename to SourceEditor
#336
thecoolwinter
merged 15 commits into
CodeEditApp:main
from
thecoolwinter:feat/editor-configuration
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
commented
Jun 17, 2025
SourceEditor
, Improve Editor ConfigurationSourceEditor
6 tasks
FastestMolasses
previously approved these changes
Jun 19, 2025
austincondiff
approved these changes
Jun 20, 2025
0xWDG
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the organization of our editor's configuration options by organizing them into a separate type from the SwiftUI API. This type is further organized into four structs based on the configuration option's effect on the editor.
Detailed Changes
SourceEditorConfiguration
struct.CodeEditSourceEditor
andTextViewController
to update configuration.CodeEditSourceEditor
's SwiftUI update method toSourceEditorConfiguration
).CodeEditSourceEditor
toSourceEditor
(requested by @austincondiff).I found a small bug with the refactor guide while making these changes. I may move them out of this PR.
Related Issues
Checklist
Screenshots
N/A no content changes