-
Notifications
You must be signed in to change notification settings - Fork 100
Expand Two-Way Editor State Bindings #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thecoolwinter
merged 27 commits into
CodeEditApp:main
from
thecoolwinter:feat/editor-state-publishers
Jun 24, 2025
Merged
Expand Two-Way Editor State Bindings #337
thecoolwinter
merged 27 commits into
CodeEditApp:main
from
thecoolwinter:feat/editor-state-publishers
Jun 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
approved these changes
Jun 24, 2025
0xWDG
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the SwiftUI API exposes one two-way binding for the editor's state: the current cursor positions. This change aims to expand the available bindings to allow developers to further control and customize the user experience.
Detailed Changes
SourceEditorState
struct, that organizes the bindings we publish into one place.scrollPosition
- matches the scroll view's scroll origin.findText
- matches the find panel text.replaceText
- matches the find panel replace text.findPanelVisible
- matches the visibility of the find panel.SourceEditor.Coordinator
to receive the new notifications and update the state struct.SourceEditor
to update the editor's state when receiving an updated state struct.Related Issues
SourceEditor
#336 for ✨ Config Getting Large #319Checklist
Screenshots
From the updated demo app, with interactive visuals for each new two-way binding.
Screen.Recording.2025-06-19.at.3.14.45.PM.mov