Skip to content

Add Text Attachment Actions #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

thecoolwinter
Copy link
Contributor

Description

Adds actions to text attachments. Actions are performed in either of the following:

  • A selection's range exactly matches that of the attachment, and the enter key is pressed.
    • For multiple cursors, if any selections match, the action is taken on all matching selections and other behaviors are ignored.
  • An attachment is double-clicked.

Attachments can return an action enum to indicate what the textview should do when the action is invoked. This allows for attachments to let the textview handle some common cases like discarding the attachment or replacing it with text, and allows attachments to perform their own logic at the same time.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Example in CodeEdit's folding attachments.

Screen.Recording.2025-06-25.at.3.12.36.PM.mov

@thecoolwinter thecoolwinter merged commit 8f02a6b into CodeEditApp:main Jun 25, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the text-attachment-actions branch June 25, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant