Skip to content

Conversation

kkamkou
Copy link
Contributor

@kkamkou kkamkou commented Feb 16, 2012

Hello Davert, please review this pr.

@DavertMik
Copy link
Member

Thanks. But can you explain what issues does it solve?

@kkamkou
Copy link
Contributor Author

kkamkou commented Feb 17, 2012

$this->session->getPage()->findLink($text) returns the element object. Current code expects iterator.
dontSeeLink doesn't work at all.

p.s. pr is not covered by the PhpUnit. My current env. has php 5.3, can't upgrade it for now.

// try yourself
    $I->seeLink('Корзина');
    $I->seeLink('Корзина', '/basket');
    $I->dontSeeLink('Кор1зина', '/basket');
    $I->dontSeeLink('Корзина', '/ba1sket');

DavertMik added a commit that referenced this pull request Feb 18, 2012
seeLink and dontSeeLink
@DavertMik DavertMik merged commit 04ecda0 into Codeception:master Feb 18, 2012
@DavertMik
Copy link
Member

Thanks again

DavertMik pushed a commit that referenced this pull request Feb 10, 2013
Samuel-Moncarey pushed a commit to Samuel-Moncarey/Codeception that referenced this pull request Jan 21, 2015
@tasselchof tasselchof mentioned this pull request May 3, 2017
Naktibalda pushed a commit to Naktibalda/Codeception that referenced this pull request Dec 28, 2020
Fixes Codeception#4

- replace use of Descriptor::getTestSignature with Descriptor::getTestSignatureUnique
@Naktibalda Naktibalda mentioned this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants