-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow Symfony 4 components #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added my repos with PRs: Installed symfony components are:
Feel to free run any tests |
Great! However I need to add some guides for this process. Dockerfile is not used for testing. What you actually need is to setup Please change minimal requirements for composer.json but change them dynamically in Travis |
Current status: Waiting merge & tag PR stecman/symfony-console-completion#79 |
db924e0
to
96eedbe
Compare
Ok, we have only one blocker: stecman/symfony-console-completion#79 If we don't see it merged in few next days we can remove it from required dependencies and allow it to be installed optionally. This feature is not that important... But we need to keep it going |
66273aa
to
015b124
Compare
Few days have passed - should we still wait? Unfortunately this cascades to other libraries and projects - they cannot be updated for sf4, as their tests cannot pass (if they are written in codeception). Thus other libraries and projects cannot be updated and so on. |
Recursion! Yes, I think it can be merged. @VolCh is it ready? |
@@ -43,7 +43,6 @@ public function runTestWithDataProvidersFailureStdout(\CliGuy $I) | |||
public function runTestWithDataProvidersFailureStderr(\CliGuy $I) | |||
{ | |||
$I->executeCommand('run -n unit DataProvidersFailureCest 2>&1',false); | |||
$I->seeInShellOutput('[Codeception\Exception\TestParseException]'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove some assertions from this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format of output in Symfony Console has changed
Added fallback for absent stecman/symfony-console-completion Rebased and splitted to atomic commits. I think it ready to work in Symfony 4 environment. Needs some CI changes after Symfony 4 release. Full support of Symfony 4 framework (its DI container first of all) I am planing check & implement at weekend in another PR. |
Thank you! |
I am starting to work on support of Symfony 4.0.0-BETA1