-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Ignore files when exporting package #5527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [install file](https://github.com/Codeception/Codeception/archive/3.0.zip) downloaded by Composer is currently 1.1 MB. These changes reduce it to ~0.4 MB, speeding up installs. Won't matter most of the time, CI servers etc. but noticeable when a developer is installing via a mobile tethered connection for example. Codeception [is installed ~373,000 times per month](https://packagist.org/packages/codeception/codeception/stats), so there's also (as noted in one of the background links below) an assumed carbon reduction bonus in not transferring the ~261 GB difference every month, but I've no idea if that's even possible to measure! :-) We use (and love!) Codeception daily, but someone more familiar with the package itself will hopefully be able to verify I've not excluded anything expected to be present on the developers machine after installing - and maybe even exclude some I haven't. I don't believe this to be a breaking change, since the files excluded are for developing Codeception, rather than to use it. Background: - https://madewithlove.be/gitattributes/ - https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/
Thank you I was always wondering how to do it 😎 |
It looks like this change broke AppVeyor build. |
Confirmed. |
Nice stats. But we forgot that almost all packages are cached by CI platforms 😀 |
This was referenced May 4, 2020
This was referenced Jun 6, 2020
simonschaufi
added a commit
to simonschaufi/MinkExtension
that referenced
this pull request
Jun 6, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/MinkExtension
that referenced
this pull request
Jun 6, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
This was referenced Jun 6, 2020
simonschaufi
added a commit
to simonschaufi/Goutte
that referenced
this pull request
Jun 6, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
This was referenced Jun 6, 2020
simonschaufi
added a commit
to simonschaufi/hamcrest-php
that referenced
this pull request
Jun 6, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/MinkExtension
that referenced
this pull request
Oct 22, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/MinkExtension
that referenced
this pull request
Oct 23, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/Laravel-Phone
that referenced
this pull request
Oct 31, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
Propaganistas
pushed a commit
to Propaganistas/Laravel-Phone
that referenced
this pull request
Nov 4, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
smartycoder
pushed a commit
to smartycoder/json-raw-encoder
that referenced
this pull request
Nov 10, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
dragonmantank
pushed a commit
to dragonmantank/cron-expression
that referenced
this pull request
Nov 24, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/avatar
that referenced
this pull request
Dec 16, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/menus
that referenced
this pull request
Dec 28, 2020
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/git-wrapper
that referenced
this pull request
Jan 2, 2021
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
This was referenced Jan 2, 2021
simonschaufi
added a commit
to simonschaufi/Geonames
that referenced
this pull request
Jan 8, 2021
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/php-slack-api
that referenced
this pull request
Feb 1, 2021
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
This was referenced Feb 1, 2021
uyab
pushed a commit
to laravolt/avatar
that referenced
this pull request
Feb 9, 2021
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
damienalexandre
pushed a commit
to jolicode/slack-php-api
that referenced
this pull request
Feb 26, 2021
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
cameronjfergus
added a commit
to cameronjfergus/sitemap
that referenced
this pull request
Mar 24, 2022
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
simonschaufi
added a commit
to simonschaufi/MinkExtension
that referenced
this pull request
Jun 15, 2022
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
lisadeloach63
pushed a commit
to lisadeloach63/laravel-ignition-error-page
that referenced
this pull request
Sep 1, 2022
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
sadafrangian3
added a commit
to sadafrangian3/laravel-ignition
that referenced
this pull request
Apr 6, 2023
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
ProFrozen
added a commit
to ProFrozen/google-api-php-client
that referenced
this pull request
May 3, 2023
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
dev-arrow
added a commit
to dev-arrow/google-api-php-client
that referenced
this pull request
Nov 26, 2024
This commit is part of a campaign to reduce the amount of data transferred to save global bandwidth and reduce the amount of CO2. See Codeception/Codeception#5527 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install file downloaded by Composer is currently 1.1 MB.
These changes reduce it to ~0.4 MB, speeding up installs. Won't matter most of the time, CI servers etc. but noticeable when a developer is installing via a mobile tethered connection for example.
Codeception is installed ~373,000 times per month, so transferring ~261 fewer GB every month should (i.e. impossible to calculate, but one website estimates) avoid 783kg of unnecessary CO2 emissions every month!
We use (and love!) Codeception daily, but someone more familiar with the package itself will hopefully be able to verify I've not excluded anything expected to be present on the developers machine after installing - and maybe even exclude some I haven't. I don't believe this to be a breaking change, since the files excluded are for developing Codeception, rather than to use it.
Background: