Improved compatibility with PHPUnit 7+ #5894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this method is public in other traits
TODO: Revert this change when support for PHPUnit 6 is dropped
Nitpick-CI
reviewed
Mar 29, 2020
| @@ -1,6 +1,7 @@ | |||
| <?php | |||
| namespace Codeception\Test; | |||
|
|
|||
| use Codeception\PHPUnit\Test As TestAbstract; | |||
There was a problem hiding this comment.
PHP keywords must be lowercase; expected as but found As
|
@Naktibalda worth merging master into this one and checking test results. |
|
@samdark I think that this change has circular dependency with Codeception/phpunit-wrapper#77 I'm not sure if these changes are worth fixing, the issue affects very few users, but there is quite a lot of work to update all phpunit-wrapper branches and adding 10 to major version number makes a mess of versioning. |
|
This change was made obsolete by work on Codeception 5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5031
Fixes #5886