Skip to content

Codeception 5.0 #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 123 commits into from
Jan 2, 2021
Merged

Codeception 5.0 #6067

merged 123 commits into from
Jan 2, 2021

Conversation

Naktibalda
Copy link
Member

@Naktibalda Naktibalda commented Dec 28, 2020 •
edited
Loading

  • Merge the latest branch of phpunit-wrapper back to Codeception/Codeception
  • Merge "Improved compatibility with PHPUnit 7+" changes made in codeception/codeception and phpunit-wrapper repos.
  • Remove some old PHPUnit compatibility hacks
  • Remove support for Symfony 3 (raise the lowest supported version to 4.4)
  • Remove support for old versions of php-dotenv 2 and 3 (possibly 4 too).
  • Remove support for codeception/stub v2
  • Upgrade to the latest major versions of the following dependencies:
    • codeception/specify 0.* to 1.* Removed dependency instead because it wasn't used by tests
    • monolog/monolog 1.* to 2.* (used by ext/Logger.php) Removed dependency instead because Logger has no tests.
    • squizlabs/php_codesniffer 2.* to 3.* Removed because it wasn't part of CI and code style wasn't enforced. It can be readded latter.
  • Delete deprecated code
  • Review all phpunit-wrapper code in src/PHPUnit/.
  • Run tests of require-dev modules in Github Actions (this change will be backported to 4.1)
  • Make codeception/stub compatible with PHPUnit 10.
  • Update files in src/PHPUnit/NonFinal directory with the latest revision of their counterparts in PHPUnit (the only difference was that they have no final keyword, because some Codeception classes extend them).
  • Make it work with PHPUnit 10 after final release.
  • Check how much work it is to make with PHPUnit 9. Support it if it is simple (e.g. a few version or method_exists conditions).
  • Repeat this process with PHPUnit 8.

There are so many commits in this pull request because I merged entire commit history of phpunit wrapper using git merge --allow-unrelated-histories
Source: https://www.w3docs.com/snippets/git/how-to-merge-two-git-repositories.html

DavertMik and others added 30 commits February 18, 2018 17:05
@DavertMik
copied from Codeception/Codeception
cc03f31
@DavertMik
update to modern class names
412645f
@DavertMik
fixed constraints
980c4a6
@DavertMik
phpunit7 compat
5725335
@DavertMik
fixed for phpunit 6
2cfb4b4
@DavertMik
merged with 7.0 shim
abfb88d
@DavertMik
fixed shim:
5d1433e
@DavertMik
Merge branch '7.0' into 6.0
164e896
@DavertMik
Merge pull request #2 from Codeception/6.0
b90b945 
fixed for phpunit 6
@DavertMik
Update shim.php
2a20c0f
@DavertMik
fixed interfaces
b98e9bf
@DavertMik
fixed phpunit interface
d5af669
@DavertMik
upgraded codecoverage shim
0c24999
@DavertMik
removed shim for phpunit < 7
19fd053
@DavertMik
enabled tests
c4def86
@Tenzian @DavertMik
src/ResultPrinter/HTML.php: Use Unique Test Signatures (Codeception#5)
4de9efc 
Fixes Codeception#4

- replace use of Descriptor::getTestSignature with Descriptor::getTestSignatureUnique
@fffilimonov @DavertMik
Make working running test with particular data set by index (Codecept…
587c963 
…ion#3)

Example: codecept run tests/acceptance/FirstCest.php:frontpageWorks#0
@DavertMik
fixed reporter to be compatible with PHPUnit 7
a938533
@DavertMik
Merge branch '7.0' of github.com:Codeception/phpunit-wrapper into 7.0
12809eb
@DavertMik
fixed showing error messages (Codeception#7)
0c1c817
@DreddyI @DavertMik
fix Codeception/phpunit-wrapper#13 (Codeception#14)
2e6719f
@fffilimonov @DavertMik
display expected/actual from phpunit assert in HTML report (Codecepti…
e3f35f1 
…on#12)
@DavertMik
Update shim.php
635b5b9
@Naktibalda @DavertMik
Fixed Dumper name in 7.0 branch (Codeception#17)
511d872
@Tenzian @DavertMik
src/ResultPrinter/HTML.php: cleanMessage() Exception Instance (Codece…
42c8fdb 
…ption#16)

Fix Codeception#15

- change exception to instance of ExpectationFailedException
@edno @DavertMik
Fix codeception issue Codeception#4888 (Codeception#19)
b3d16b1
@edno @DavertMik
Improve support of PHPUnit warning status (Codeception#22)
e8528cb
Fixed Report compatibility with PHPU7
0999d1b
@fanfromzp
Fix bug
3025acd 
Fix bug
Warning: Declaration of Codeception\PHPUnit\ResultPrinter\UI::printDefect(PHPUnit\Framework\TestFailure $defect, $count): void should be compatible with PHPUnit\TextUI\ResultPrinter::printDefect(PHPUnit\Framework\TestFailure $defect, int $count): void
@Naktibalda
Require phpunit 7.1
32d5649 
Because Codeception#23 and Codeception#25 makes wrapper incompatible with phpunit 7.0
@Naktibalda
Remove dependency on phpunit-wrapper
78f0a69
@Naktibalda
Made IgnoreIfMetadataBlocked::getMetadata() public
426301c 
Because this method is public in other traits
@Naktibalda
Move JSON and TAP loggers to separate files
a84602c
@Naktibalda
Delete old aliases
242bc79 
Codeception\TestCase\Test
Codeception\Platform\Group
Codeception\Platform\Extension
Codeception\TestCase
@Naktibalda
Delete CodeCoverage blacklist functionality
56424f2 
It wasn't working since PHPUnit 5 anyway
@Naktibalda
Updated custom reporter tests to work with PHPUnit 7+
9c2635a
@Naktibalda
Remove support for Symfony <4.4
28a0a96
@Naktibalda
Removed unused field
239b2ec
@Naktibalda
Bump required minor versions of some dependencies, require codeceptio…
3bf56c2 
…n/stub 3
@Naktibalda
Remove dev dependency on Monolog
dbf4109 
Because Logger extension has no tests
@Naktibalda
Remove dev dependency on codeception/specify
7d0ecba
@Naktibalda
Remove dev dependency on php codesniffer
2efa5fd 
It has never been a part of CI
@Naktibalda
Remove support for vlucas/phpdotenv v2 and v3
7cbb8b9
@Naktibalda
Deleted Codeception\Util\Stub class
20efa5f 
It was replaced by Codeception\Stub in 2.3.8
@Naktibalda
Remove settings:bootstrap setting
f56b5b2 
It was replaced by top level bootstrap setting in 3.1.0
@Naktibalda
CI: Run module-asserts and module-filesystem tests
f1b9684
@Naktibalda
CI: Run module-phpbrowser tests
f180f92
@Naktibalda
CI: Run module-db Sqlite tests
f3ce511 
Mysql and Postgres require adding too many additional dependencies to build for little benefit
@Naktibalda
Copy link
Member Author

phpunit-wrapper runs module-asserts tests because PHPUnit removes or changes some assertions in breaking way in every major release.
I added running tests of other modules because they are already there, so it is a small change, and I hope that they will prevent us from breaking some module related functionality.
They can be removed later if build process takes too long.

@Naktibalda Naktibalda changed the title WIP: Codeception 5.0 Codeception 5.0 Dec 31, 2020
@Naktibalda
Copy link
Member Author

I think that this branch can be merged now to allow other people to contribute to 5.0.
PHPUnit 10 is a moving target and PHPUnit10 support won't be complete until 10.0.0 is released on 5th of February.
I will open another pull request for PHPUnit 10.

@DavertMik
Copy link
Member

I think that this branch can be merged now to allow other people to contribute to 5.0.

Absolutely agree!
Going to clone it now

@DavertMik DavertMik merged commit 8d6b2dc into Codeception:5.0 Jan 2, 2021
@Naktibalda Naktibalda mentioned this pull request Jan 2, 2021
Closed
@ThomasLandauer
Copy link
Member

One more TODO: Remove Cept format completely, see #6144 (comment)

@ThomasLandauer ThomasLandauer mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitpick-CI Nitpick-CI Nitpick-CI left review comments

@DavertMik DavertMik Awaiting requested review from DavertMik

@samdark samdark Awaiting requested review from samdark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.