Skip to content

Conversation

weeg
Copy link

@weeg weeg commented Oct 2, 2023

It makes possible to use actors inside dataProviders. It's a very useful functionality, during testing it happens that data need to be retrieved ie.: from the database, but it's not possible to use it with the current solution. There was a discussion about it in the past: #4087

I am not sure if I implemented it in the correct way, I am new to Codeception and open source contribution as well. What do you think of it @DavertMik?

Copy link
Member

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weeg Thanks for the PR
I like it in general and I have some ideas to improve it
Please tell what you think

@W0rma
Copy link
Contributor

W0rma commented Dec 3, 2023

@DavertMik @Naktibalda Are you okay with the latest changes in this PR?

Seems like the author addressed all comments with the latest commit.

@Naktibalda Naktibalda merged commit 31103d2 into Codeception:5.0 Dec 22, 2023
@Naktibalda
Copy link
Member

@weeg @W0rma @DavertMik Could someone document this new feature somewhere?

https://github.com/Codeception/codeception.github.com/tree/master/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants