Skip to content

Conversation

TavoNiievez
Copy link
Member

I cherry-picked the commit from my other PR (#6746) to demonstrate that the tests run correctly.
I will delete it as soon as it is merged.

This PR should be merged with the Squash and merge strategy.

@TavoNiievez TavoNiievez requested a review from Naktibalda March 20, 2024 22:14
@TavoNiievez TavoNiievez marked this pull request as ready for review April 1, 2024 05:19
Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version is it going to be? 5.2.0? 6.0.0?

I think that 5.1 branch should stay compatible with PHP 8.0 in cases there is some critical bug that must be fixed.

@TavoNiievez
Copy link
Member Author

@Naktibalda In my PR for the command folder I also had to move the minimum version of Symfony to 5.4.

I don't plan to add any breaking changes, I'm just going to remove inconsistencies in the code where I find them or rewrite small pieces of code for some simpler or more modern alternative from a Symfony or PHP version point of view.
Considering this, it can be called 5.2
People who need Symfony 4.4 or PHP 8.0 can stay on Codeception 5.1 and those who can upgrade will do so without having to change anything in their code.

@TavoNiievez TavoNiievez requested a review from Naktibalda April 9, 2024 15:46
@Naktibalda Naktibalda changed the base branch from 5.1 to 5.2 May 16, 2024 17:03
@TavoNiievez TavoNiievez merged commit 17b6765 into Codeception:5.2 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants