Simplify command classes #6750
Merged
Simplify command classes #6750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naktibalda
requested changes
May 16, 2024
| $this->setDefinition([ | ||
| new InputArgument('group', InputArgument::REQUIRED, 'Group class name'), | ||
| ]); | ||
| $this->addArgument('group', InputArgument::REQUIRED, 'Group class name'); | ||
| } | ||
|
|
||
| public function getDescription(): string | ||
| { | ||
| return 'Generates Group subscriber'; |
There was a problem hiding this comment.
This description could be moved to setDescription too.
|
@Naktibalda FYI, this is supposed to be the first of several PR's and I'm supposed to follow up with the other folders inside src/, I don't know how long that's going to take me, so you can take that into account when releasing 5.2 or not. |
Naktibalda
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
221 additions, 476 deletions.