Skip to content

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Jul 26, 2024

https://wiki.php.net/rfc/deprecate-implicitly-nullable-types deprecates implicitly nullable parameter types in PHP 8.4

Copy link
Contributor

@burned42 burned42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@TavoNiievez
Copy link
Member

@W0rma Do you think you can raise a PR for the 5.2 branch as well?

@W0rma
Copy link
Contributor Author

W0rma commented Jul 27, 2024

@W0rma Do you think you can raise a PR for the 5.2 branch as well?

@TavoNiievez Sure - see #6775

@TavoNiievez TavoNiievez merged commit 73fd3c9 into Codeception:5.1 Jul 28, 2024
8 checks passed
@W0rma W0rma deleted the explicit-nullable-parameter-type branch March 11, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants