Fix loading keywords in behat/gherkin v4.12 #6839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TavoNiievez
approved these changes
Apr 1, 2025
|
Thank you @W0rma |
|
@TavoNiievez can we get a release for this? I'd rather not have to stick a crappy workaround in my |
|
@francislavoie If there are no unforeseen events I will release version 5.3.0 before the end of the week. |
|
Thanks, 5.3.0 seems to work fine for me (I don't use Gherkin at all) |
W0rma
added a commit
to W0rma/Codeception
that referenced
this pull request
May 7, 2025
(cherry picked from commit d7b88e7)
1 task
TavoNiievez
pushed a commit
that referenced
this pull request
May 7, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6833
Replaces #6836
I overlooked that the release notes https://github.com/Behat/Gherkin/releases/tag/v4.12.0 already suggest a simple way to load the keywords independently from the file path:
This PR uses this approach and bumps the minimum version of
behat/gherkinto 4.12 which should be okay because this version does still support PHP 8.1 which is also the case for codeception v5.