feat: Add support for more data types #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! 🎉🎉 Thanks for your contribution. I like very much the use of |
Closed
|
I was using an old version of the library, and this behaviour was driving me crazy. Thanks a lot Arnold!!! /tip 29 @arnold095 How to receive this tip?@arnold095 go to your settings and make sure your Stripe account is configured, otherwise you won't be able to receive payments. |
|
🥳 @RubenRuCh completed the payment of $29.00 as a tip for @arnold095 💰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Primitivesutility works well when the types are value objects or an array of value objects. The problem is when in an entity apart from value objects there are also simpler data types (booleans, strings, numbers, etc.), as well as possible undefined values.This behaviour can be seen in this playground
With my proposal it is possible to infer the cases that were already covered as well as the new cases I have outlined above.
this is the playground of my proposal