Skip to content

Feature: Adds option to define host address #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature: Adds option to define host address #2

wants to merge 2 commits into from

Conversation

docnoe
Copy link

@docnoe docnoe commented Jun 20, 2019

Adds option to specify a host address e.g. to make it possible to access the editor from outside localhost.

docnoe and others added 2 commits June 20, 2019 12:33
@docnoe
Feature(index.ts): Adds option to define host
1794d28 
Makes it possible to specify a host address to access the editor if from outside localhost.
@docnoe
Adds dist folder to version control
72f62ef
Codermar
Codermar requested changes Mar 28, 2020
View reviewed changes
Copy link
Owner

@Codermar Codermar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you only need the change in src/index.ts probably or if needed in any of the ts files. The build would override files in the build directory anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codermar Codermar Codermar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@docnoe @Codermar