Skip to content

Removing some redundancies, add style scoped and change name of component of doublequotes to singlequotes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2017
Merged

Removing some redundancies, add style scoped and change name of component of doublequotes to singlequotes #2

merged 3 commits into from
Jun 29, 2017

Conversation

lucasbastianik
Copy link
Contributor

Hi Andre, what do you think about this optimizations?

@CorentinAndre
Copy link
Owner

Hi, everything is perfect except:

  • single quotes vs double. I use double quotes everywhere else in the snippets so better to keep double quotes for consistensy
  • scoped should be specified as a variable like so <style${2: lang="${3:scss}"} ${4:scoped}>. This way, you can choose whether or not you want your style scoped, as it is non mandatory.

Can you update your PR with those changes ?

Otherwise your PR is great, thank you ! 😄

@lucasbastianik
Copy link
Contributor Author

lucasbastianik commented Jun 24, 2017 •
edited
Loading

Hello @CorentinAndre

I updated the code! 😉

@CorentinAndre CorentinAndre merged commit de3a31f into CorentinAndre:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasbastianik @CorentinAndre