Skip to content

Update links in readmes #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2022
Merged

Update links in readmes #3378

merged 1 commit into from
Sep 16, 2022

Conversation

benjaminjb
Copy link
Contributor

@benjaminjb benjaminjb commented Sep 9, 2022 •
edited
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

A few links in the readmes no longer worked, as per this issue.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:
Issue [sc-15609]

@benjaminjb benjaminjb marked this pull request as ready for review September 12, 2022 15:09
benjaminjb
benjaminjb commented Sep 13, 2022
View reviewed changes
benjaminjb
benjaminjb commented Sep 13, 2022
View reviewed changes
benjaminjb
benjaminjb commented Sep 13, 2022
View reviewed changes
benjaminjb
benjaminjb commented Sep 13, 2022
View reviewed changes
benjaminjb
benjaminjb commented Sep 13, 2022
View reviewed changes
cbandy
cbandy reviewed Sep 15, 2022
View reviewed changes
cbandy
cbandy approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@cbandy cbandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash before merging.

@benjaminjb
Update links in readmes
fa4dedd 
* update links
* update linter (disable contextcheck, add contextcheck to .next)
* update test: pin to 1.24 rather than latest

Issue [sc-15609]
@benjaminjb benjaminjb merged commit fbdb4e1 into CrunchyData:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlecuyer andrewlecuyer andrewlecuyer left review comments

@cbandy cbandy cbandy approved these changes

+1 more reviewer

@maaft maaft maaft left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminjb @cbandy @maaft @andrewlecuyer