Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): rename system-tests scenario #6034

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

cbeauchesne
Copy link
Contributor

@cbeauchesne cbeauchesne commented Jun 6, 2023

Following DataDog/system-tests/pull/1117, APPSEC_IP_BLOCKING and APPSEC_IP_BLOCKING_MAXED scenarios has been merged and renamed in APPSEC_BLOCKING_FULL_DENYLIST

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@cbeauchesne cbeauchesne requested a review from a team as a code owner June 6, 2023 09:14
@cbeauchesne cbeauchesne changed the title System-tests scenario renaming : APPSEC_IP_BLOCKING / APPSEC_IP_BLOCKING_MAXED => APPSEC_BLOCKING_FULL_DENYLIST Rename System-tests scenario Jun 6, 2023
@cbeauchesne cbeauchesne changed the title Rename System-tests scenario chore(test): Rename System-tests scenario Jun 6, 2023
@cbeauchesne cbeauchesne changed the title chore(test): Rename System-tests scenario chore(test): rename system-tests scenario Jun 6, 2023
@cbeauchesne cbeauchesne added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 6, 2023
@cbeauchesne cbeauchesne merged commit c24f467 into 1.x Jun 6, 2023
@cbeauchesne cbeauchesne deleted the cbeauchesne/system-tests-scenario branch June 6, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants