Skip to content

Remove stickyfill #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

Remove stickyfill #10688

merged 1 commit into from
May 27, 2021

Conversation

bgdeutsch
Copy link
Collaborator

What does this PR do?

Remove Stickyfill.js library

Motivation

a) The library is no longer maintained
b) All modern browsers have implemented position: sticky
c) reduce JS bloat / general maintenance

Preview

https://docs-staging.datadoghq.com/brian.deutsch/remove-stickyfill/

  • Elements with sticky such as the left side navs and site/lang selectors continue to look and function properly
  • No related JS errors in console

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@bgdeutsch bgdeutsch requested review from a team as code owners May 27, 2021 15:57
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label May 27, 2021
ruthnaebeck
ruthnaebeck approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ruthnaebeck ruthnaebeck merged commit de4c778 into master May 27, 2021
@ruthnaebeck ruthnaebeck deleted the brian.deutsch/remove-stickyfill branch May 27, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidejones davidejones davidejones approved these changes

+1 more reviewer

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgdeutsch @davidejones @ruthnaebeck