CI-app - Swift - Added more environment variables to some CI #10818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project when running in some CI's
sarina-dd
approved these changes
Jun 11, 2021
|
@kayayarai Heads up on this one in case you want to work your table magic 🎩 ! It looks like two tables near the bottom overflow into the ToC. |
|
Thanks for the heads up. I've been giving these two the pass so that they remain consistent with the similar tables around them, and the overlap isn't too too terrible. LGTM to ship. |
kayayarai
approved these changes
Jun 11, 2021
bgdeutsch
pushed a commit
that referenced
this pull request
Jul 8, 2021
…mmit-info CI-app - Swift - Added more environment variables to some CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds more environment variables that should be added to the project when running in some CI's
Motivation
We added new support for these variables and must be documented
Preview
https://docs-staging.datadoghq.com/origin/nachoBonafonte/CI-app-Swift-commit-info
Reviewer checklist