-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding iframe case to troubleshooting guide #10869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthnaebeck
suggested changes
Jun 17, 2021
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
ruthnaebeck
approved these changes
Jun 17, 2021
apigirl
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Adding translations * [agent] Add FAQ on how to run the MacOS Agent as a system service * Cleanup & use table * CI-app - Added more environment variables that might be added to the project when running in some CI's * Specify that the system tray application does not work * Composite Monitor notifications update. * [rum] new billing details page (#10804) * [rum] new billing details page * Apply suggestions from code review Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Apply suggestions from code review Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Bump SDK (#10815) Co-authored-by: packages <packages@datadoghq.com> * Update CI Visibility Ruby instructions with latest tracer version * Small fix in header (#10809) * Small fix in header * Update content/en/synthetics/guide/identify_synthetics_bots.md * Update content/en/synthetics/guide/identify_synthetics_bots.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/guide/identify_synthetics_bots.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/guide/identify_synthetics_bots.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * [WEB-1444]Brooklyne.finni/update api icon (#10812) * update icon in product dropdown menu for api * update api icon src across different translations and provide mozilla product menu fix * Update python.md (#10806) Match how https://github.com/DataDog/dd-trace-py casts trace_id & spand_id as strings This also protects again issues where a forwarding library may have trouble with large integers (as is happening with the datadog fluent bit forwarding plugin - which is currently rounding down any integers > the largest signed integer to 9223372036854775807) * adding_note_for_32_bit Our storage backend will convert values to 32 bit. Sometimes this means large values will be converted to their 32 bit counterpart. We should specify this. * Apply suggestions from code review * (DOCS-2116) Remove outdated screenshot * Remove image files * Readd the Gemfile code change * Apply suggestions from code review * Update Password Reset docs to include EU endpoint This PR updates the password reset docs to include the link where customers in the EU need to go to reset their passwords * Apply suggestions from code review * add new blog link * DOCS-2031 Heading exceptions for dogweb integrations * developer overview updates - new (borked a branch) (#10366) * borked a braanch * Apply suggestions from code review Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Apply suggestions from code review Co-authored-by: H "Waldo" G <gwaldo@gmail.com> * Update _index.md * adding in Ruths partial * completely wrong partial Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> Co-authored-by: H "Waldo" G <gwaldo@gmail.com> * Update frameworks_and_benchmarks.md Adding the new frameworks + minor tweaks to legal disclaimer language. * Use macOS * [rum] added beforesend context docs * Regenerate client from commit 6c1fcab of spec repo * catch dt dd tags * Update _index.md * changing whitelist to include list since it's not a UI element * Regenerate client from commit 0664044 of spec repo * updating to remove helm stable line, closes #10834 * Apply suggestions from code review Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> * Apigee doc updates (#10811) * init commit apigee docs * update syslog param regions * Apply suggestions from code review Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * DOCS-2031 Add exceptions for Integrations Extras * additional exceptions * Update docker-deprecation.md A few minor nits * Update data_collected.md * Editor review Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> * [rum] review changes * [rum] fix link * Adding default polling timeout * Kubernetes agent: Fix error in deployment command * Regenerate client from commit 92478ee of spec repo * [agent] helm chart install best-practice update * Fix JSON examples of nested arrays (#10844) * Fix JSON examples of nested arrays Seen in https://docs.datadoghq.com/api/latest/dashboards/#create-a-shared-dashboard `visibles_tags` don't have the proper type. This fixes it, plus a small refactoring. * rebuilt json Co-authored-by: david.jones <david.jones@datadoghq.com> * deemphasize ruby * Update after vincent review * Changes from initial review * Update content/en/synthetics/ci.md Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com> * Update content/en/synthetics/ci.md * Update content/en/synthetics/ci.md * Update content/en/synthetics/ci.md * Update content/en/agent/kubernetes/_index.md * Apply suggestions from code review Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> Co-authored-by: Kathy L. <kathy.lin@datadoghq.com> * fix a link * Move link to text over the API for precision. * Fix in page link since heading changed * Re-order and simplify guide steps * Last step is a substep * Adding translations * Display estimated usage for Analyzed Logs (security) * Add priority override instructions * [ci-app] Add instructions to enable CI Visibility in Jenkins * Update content/en/continuous_integration/setup_pipelines/jenkins.md Co-authored-by: Daniel Rodriguez Hernandez <daniel.rodriguezhernandez@datadoghq.com> * Apply suggestions from code review Co-authored-by: Jorie Helwig <jorie.helwig@datadoghq.com> * Fix typo in build failure error * Update content/en/continuous_integration/setup_pipelines/jenkins.md Co-authored-by: Jorie Helwig <jorie.helwig@datadoghq.com> * [ci-app] Update Python tracer version * [apm] add warning on otel collector docs about v0.28 * DOCS-1636 Lint headings * Add blog link * Reorging the Developer section and adding custom check and service check info * adding the cloudformation file * Add saved views instructions for monitors (#10543) * Add saved views instructions for monitors * add image for overview * add default monitor image * update image extension * update the overview image * change the default image * Apply suggestions from code review Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: Ruth Naebeck <ruthnaebeck@gmail.com> * Regenerate client from commit 3efd10d of spec repo (#10870) Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> * Adding iframe case to troubleshooting guide (#10869) * Adding iframe case to troubleshooting guide * Update content/en/synthetics/troubleshooting/_index.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * updating links and adding check content on landing page and trying to fix service check API link * fixing broken email link * adding missing community page and aliases * updating links for files that were moved around * Export environment variables in Ruby example (#10866) This was suggested by a colleague, the environment variables by themselves cannot just be copy-pasted to the shell without `export`. It also seems harmless for those who don't need an export: then can always remove it. * Add micronaut and restlet to compatibility docs (#10873) * Remove extra 'detection' word There was extra 'detection' word in the first line of this doc. * Bump SDK * Adding translations * Remove duplicate paragraph * make nav links to api non async (#10879) * nav updates * fixing a nav weight * updates to clean things up (#10881) * Adding documentation about private location monitoring * Adding examples to downtime documentation * Update content/en/synthetics/private_locations/_index.md Co-authored-by: Sarina Bloodgood <57639676+sarina-dd@users.noreply.github.com> * Update content/en/synthetics/private_locations/_index.md * Update content/en/synthetics/private_locations/_index.md * Update content/en/synthetics/private_locations/_index.md * Adding images * Variables clarification (#10872) * Variables clarification Moving variables usage out of the variables step itself Moving steps to ### * Update content/en/synthetics/browser_tests/actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/browser_tests/actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/browser_tests/actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/browser_tests/actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/browser_tests/actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update content/en/synthetics/browser_tests/actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update actions.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sarina Bloodgood <57639676+sarina-dd@users.noreply.github.com> * Update CONTRIBUTING.md * Update list-of-api-source-attribute-value.md Fix API source attribute of Amazon health Reference: https://datadoghq.atlassian.net/browse/EVMS-93?focusedCommentId=425009 * Update dotnet-framework.md * Add a note on AWS resource exclusion * Update aws.md * Adding translations * GA-ing Edge on Browser tests * [rum] added a guide on enriching data * Update app-that-requires-login.md * Regenerate client from commit 8327a94 of spec repo * fix indent * Add vsphere duplicated hosts troubleshooting * Regenerate client from commit 609ca23 of spec repo * Update content/en/synthetics/browser_tests/_index.md * Add Helm instructions and cleanup Daemonset approach * Add a second downtime example by monitor name * Add images * Update content/en/monitors/downtimes.md Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> * Update content/en/monitors/downtimes.md Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> * Apply suggestions from code review * Apply edit suggestions from code review * Update content/en/agent/cluster_agent/setup.md * fix tags * formatting, indenting * Adding translations * send metrics to api with compression to reduce 413 Payload too large * [rum] add link to context types in repository * Update _index.md * Update _index.md * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update _index.md * Addition for SMS via email alerts * Add files via upload * Add files via upload * Update _index.md * Update _index.md * Add files via upload * Update _index.md * Regenerate client from commit ac88040 of spec repo * Update request_json.md * Add files via upload * Update _index.md * Apply suggestions from code review * use git mv to move files * add aliases * Update can-i-send-sms-notifications-in-datadog.md * Update menu nav * Fix custom metrics nav * small edits to units page * DOCS-2102 (#10907) * DOCS-2102 Ruth and Kaylyn picked up the bulk of the work for this ticket (thanks @ruthnaebeck and @apigirl!) so I added a section above Pronouns about inclusive language with recommended and not recommended examples. * Inclusive Language Guidelines Adding inclusive language to our Documentation Style Guide. Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * small edits for editorial review * skip the bump version action on forks (#10893) * updating to clean up #10772 * another fix * Apply suggestions from code review Co-authored-by: Sarina Bloodgood <57639676+sarina-dd@users.noreply.github.com> * i * removing generated file * removing stray thing * fixing merge grossness * fixing merge grossness * more cleanup * more cleanup * cleanup * more cleanup * removing the file * more cleanup * one last one * ONE SPACE KILLED A WHOLE SECTION * Apply suggestions from code review Co-authored-by: Sarina Bloodgood <57639676+sarina-dd@users.noreply.github.com> Co-authored-by: guacbot <guacbot@users.noreply.github.com> Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com> Co-authored-by: Ignacio Bonafonte <nacho.bonafontearruga@datadoghq.com> Co-authored-by: eannamacken <66995408+eannamacken@users.noreply.github.com> Co-authored-by: Hugo Delaby <hugo.delaby@datadoghq.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: packages <packages@datadoghq.com> Co-authored-by: Fernando Mayo <fernando@datadog.com> Co-authored-by: Margot Lepizzera <margot.lepizzera@datadoghq.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: Brooklyne Finni <brooklyne.finni@datadoghq.com> Co-authored-by: John Penner <jpenner@gmail.com> Co-authored-by: Michael Carlos <39385362+mikepcarlos@users.noreply.github.com> Co-authored-by: Sarina Bloodgood <57639676+sarina-dd@users.noreply.github.com> Co-authored-by: Jorie Helwig <jorie.helwig@datadoghq.com> Co-authored-by: Jorie <joriephoto@gmail.com> Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> Co-authored-by: Alexandra Fren <35177685+alexandrafren@users.noreply.github.com> Co-authored-by: Sarina <sarina.bloodgood@datadoghq.com> Co-authored-by: Ruth Naebeck <ruthnaebeck@gmail.com> Co-authored-by: cswatt <cecilia.watt@datadoghq.com> Co-authored-by: H "Waldo" G <gwaldo@gmail.com> Co-authored-by: ItsYamnitsky <41908270+ItsYamnitsky@users.noreply.github.com> Co-authored-by: david.jones <david.jones@datadoghq.com> Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com> Co-authored-by: Cameron Yick <hydrosquall@users.noreply.github.com> Co-authored-by: Manu NALEPA <nalepae@gmail.com> Co-authored-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com> Co-authored-by: Kathy L. <kathy.lin@datadoghq.com> Co-authored-by: mtremsal <marc.tremsal@gmail.com> Co-authored-by: Nils <nils.bunge@datadoghq.com> Co-authored-by: Fernando Mayo <fernando.mayo@datadoghq.com> Co-authored-by: Daniel Rodriguez Hernandez <daniel.rodriguezhernandez@datadoghq.com> Co-authored-by: ericmustin <mustin.eric@gmail.com> Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com> Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com> Co-authored-by: Andrew Southard <andrew.southard@datadoghq.com> Co-authored-by: Morsalin Billah <morsalin.billah@datadoghq.com> Co-authored-by: Victor Skvortsov <vds003@gmail.com> Co-authored-by: cyn <cynthia.dominguez@datadoghq.com> Co-authored-by: aquiladayc <56868556+aquiladayc@users.noreply.github.com> Co-authored-by: Julian <julian.kozianski@datadoghq.com> Co-authored-by: Marc Santos <marc.santos@datadoghq.com> Co-authored-by: Paul Coignet <paul.coignet@datadoghq.com> Co-authored-by: JacksonDavenport <jack.davenport@datadoghq.com> Co-authored-by: Pranay <pgkamat@users.noreply.github.com> Co-authored-by: ck3nn <68287795+ck3nn@users.noreply.github.com>
jtappa
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Adding iframe case to troubleshooting guide * Update content/en/synthetics/troubleshooting/_index.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding iframe case to troubleshooting guide
Motivation
Preview
https://docs-staging.datadoghq.com/margot.lepizzera/iframe/synthetics/troubleshooting/#browser-tests
Additional Notes
Reviewer checklist