Skip to content

Conversation

tianchu
Copy link
Contributor

@tianchu tianchu commented Aug 10, 2021

What does this PR do?

The precommit hooks making the PR appear more complex than it really is. The actual changes are:

  • Ask users to set DATADOG_API_KEY env var when using the Datadog CLI with Lambda Extension.
  • Ask users to quote the Forwarder ARN value when using the Datadog CLI with the Forwarder Lambda.
  • Move the Datadog CLI to the first tab/choice for installation.
  • Add a paragraph to recommend people using the Datadog CLI.

Motivation

Datadog CLI is out of beta, and it is the easiest way to set up Datadog serverless monitoring and it works regardless whether you are using a specific devtool.

Preview

Additional Notes


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@tianchu tianchu requested review from a team as code owners August 10, 2021 20:50
@tianchu tianchu force-pushed the tian.chu/recommend-using-datadog-cli branch from 281f376 to 962daee Compare August 10, 2021 21:03
@@ -17,6 +17,51 @@ After you have installed the [AWS integration][2] and the [Datadog Forwarder][3]
## Configuration

{{< tabs >}}
{{% tab "Datadog CLI" %}}

Use the Datadog CLI to set up instrumentation on your Lambda functions in your CI/CD pipelines or from your local command-line interface. The CLI command automatically adds the Datadog Lambda library and extension to your functions using Lambda Layers, and configures your functions to send metrics, traces, and logs to Datadog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the Datadog CLI to set up instrumentation on your Lambda functions in your CI/CD pipelines or from your local command-line interface. The CLI command automatically adds the Datadog Lambda library and extension to your functions using Lambda Layers, and configures your functions to send metrics, traces, and logs to Datadog.
Use the Datadog CLI to set up instrumentation on your Lambda functions in your CI/CD pipelines or from your local command-line interface. The CLI command automatically adds the Datadog Lambda Library and extension to your functions using Lambda Layers. It also configures your functions to send metrics, traces, and logs to Datadog.

@github-actions github-actions bot added Guide Content impacting a guide serverless labels Aug 10, 2021
@cswatt cswatt merged commit 1acbe83 into master Aug 10, 2021
@cswatt cswatt deleted the tian.chu/recommend-using-datadog-cli branch August 10, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide serverless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants