profiling: clarify Go delta profiling default configuration #13465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta profiling has been enabled by default for the Go profiling client library since it was introduced in version 1.33.0. This documentation made it seem as though it was only enabled by default in version 1.35.0 when that version actually added the option to *disable* delta profiles.
alai97
suggested changes
Mar 22, 2022
alai97
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clarifies how long delta profiling has been on by default for the Go profiling client library.
Motivation
Delta profiling has been enabled by default for the Go profiling client
library since it was introduced in version 1.33.0. This documentation
made it seem as though it was only enabled by default in version 1.35.0
when that version actually added the option to disable delta profiles.
Preview
https://docs-staging.datadoghq.com/nick.ripley/clarify-go-delta-profiling-defaults/tracing/profiler/search_profiles
Additional Notes
Reviewer checklist