Update integrations pages #13740
Closed
Update integrations pages #13740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgdeutsch
commented
Apr 19, 2022
| @@ -513,6 +513,42 @@ def replace_image_src(markdown_string, integration_name): | |||
| else: | |||
| return markdown_string | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
will iterate on this solution, for now it needs to handle cases where the pricing header is duplicated in integration readme
davidejones
approved these changes
Apr 19, 2022
|
I spot checked a bunch of pages and they look fine, but it looks like it may have introduced a regression on the left nav - it is opening the wrong section based on which page you are on |
…g/documentation into brian.deutsch/integrations-update
|
see #13746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hide pricing info
Motivation
integrations readme files changed which broke the docs build
likely we will need a more comprehensive solution in the near future and potentially a check on marketplace/other integrations PRs to ensure Docs build is stable as well
Preview
https://docs-staging.datadoghq.com/brian.deutsch/integrations-update/integrations/
https://docs-staging.datadoghq.com/brian.deutsch/integrations-update/integrations/rapdev_solaris_agent/
https://docs-staging.datadoghq.com/brian.deutsch/integrations-update/integrations/rapdev-snmp-profiles/
SetupandPricinginfo should be removed from integrations detail pagesPricing tables are removed as well, not just header
Additional Notes
Reviewer checklist