Skip to content

DOCS-2293, DOCS-3308, and DOCS-3156 Using Synthetic Test Monitors Guide #13988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 27, 2022
Merged

DOCS-2293, DOCS-3308, and DOCS-3156 Using Synthetic Test Monitors Guide #13988

merged 9 commits into from
May 27, 2022

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented May 10, 2022

What does this PR do?

Adds a guide about Synthetic test monitors.

Motivation

DOCS-2293, DOCS-3308, and DOCS-3156

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@alai97
DOCS-2293
1c38cea 
Includes DOCS-3308 and DOCS-3156.
@alai97 alai97 requested a review from peculiarism May 10, 2022 01:22
@alai97 alai97 requested a review from a team as a code owner May 10, 2022 01:22
@github-actions github-actions bot added Guide Content impacting a guide Images Images are added/removed with this PR synthetics Content changed in the synthetics folder labels May 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022 •
edited
Loading

Preview links (active after the build_preview check completes):
https://docs-staging.datadoghq.com/alai97/synthetics-test-monitors-guide/monitors/create/
https://docs-staging.datadoghq.com/alai97/synthetics-test-monitors-guide/monitors/guide/
https://docs-staging.datadoghq.com/alai97/synthetics-test-monitors-guide/synthetics/guide/
https://docs-staging.datadoghq.com/alai97/synthetics-test-monitors-guide/synthetics/guide/synthetic-test-monitors

@peculiarism
Copy link

@MargotLepizzera could you give this a review from an Alerting perspective? If you have time 🙏🏻

peculiarism
peculiarism suggested changes May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
MargotLepizzera
MargotLepizzera reviewed May 10, 2022
View reviewed changes
@urseberry urseberry added the editorial review Waiting on a more in-depth review label May 10, 2022
@alai97 alai97 added the WORK IN PROGRESS No review needed, it's a wip ;) label May 10, 2022
@github-actions github-actions bot added the monitors Content changed in the monitors folder label May 10, 2022
@alai97 alai97 requested a review from peculiarism May 10, 2022 21:07
peculiarism
peculiarism reviewed May 12, 2022
View reviewed changes
@alai97
SME Review #2
82209f4 
Co-authored-by: Beth G <beth@datadoghq.com>
@alai97 alai97 requested a review from peculiarism May 13, 2022 00:52
@alai97 alai97 changed the title DOCS-2293, DOCS-3308, and DOCS-3156 Understanding Synthetic Tests and Alerting Monitors Guide DOCS-2293, DOCS-3308, and DOCS-3156 Understanding Synthetic Test Monitors Guide May 13, 2022
@alai97 alai97 changed the title DOCS-2293, DOCS-3308, and DOCS-3156 Understanding Synthetic Test Monitors Guide DOCS-2293, DOCS-3308, and DOCS-3156 Using Synthetic Test Monitors Guide May 13, 2022
peculiarism
peculiarism reviewed May 18, 2022
View reviewed changes
Copy link

@peculiarism peculiarism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking much better! We just need to confirm with @MargotLepizzera on the row for Synthetic Monitoring in the Create Monitors space ✨

@alai97
SME Review
a9ee659 
Co-authored-by: Beth G <beth@datadoghq.com>
@alai97 alai97 requested a review from peculiarism May 18, 2022 15:46
@alai97 alai97 removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 18, 2022
urseberry
urseberry reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have time to retake the screenshots, they would be clearer and easier to read at a higher zoom level.

urseberry
urseberry approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Austin! This page is great. It has really clear information about how to set up the monitors, and what they can and cannot do.

I do have some suggestions, but they are all matters of preference. I'll go ahead and approve the PR.

@alai97 @urseberry
Doc Review
44e89c0 
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@alai97 alai97 merged commit cc11a61 into master May 27, 2022
@alai97 alai97 deleted the alai97/synthetics-test-monitors-guide branch May 27, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urseberry urseberry urseberry approved these changes

@MargotLepizzera MargotLepizzera Awaiting requested review from MargotLepizzera

+1 more reviewer

@peculiarism peculiarism peculiarism approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR monitors Content changed in the monitors folder synthetics Content changed in the synthetics folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alai97 @peculiarism @MargotLepizzera @urseberry